Skip to content

Kl gmt 1666 gamut beta#3391

Draft
LinKCoding wants to merge 46 commits into
cass-gmt-1607-publishfrom
kl-gmt-1666-gamut-beta
Draft

Kl gmt 1666 gamut beta#3391
LinKCoding wants to merge 46 commits into
cass-gmt-1607-publishfrom
kl-gmt-1666-gamut-beta

Conversation

@LinKCoding

@LinKCoding LinKCoding commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Overview

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • Version plan added/updated (or not needed)
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to story X
  2. Do something
  3. Do that something in dark mode
  4. Check it with VO
  5. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@LinKCoding
LinKCoding changed the base branch from main to cass-gmt-1607-publish July 1, 2026 18:25
@nx-cloud

nx-cloud Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 7b0ce6e

☁️ Nx Cloud last updated this comment at 2026-07-16 14:01:50 UTC

@codecov

codecov Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.17%. Comparing base (73872b1) to head (7b0ce6e).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
packages/gamut/src/Tip/shared/FloatingTip.tsx 80.00% 2 Missing ⚠️
Additional details and impacted files 
@@                  Coverage Diff                   @@
##           cass-gmt-1607-publish    #3391   +/-   ##
======================================================
  Coverage                  90.16%   90.17%           
======================================================
  Files                        273      271    -2     
  Lines                       5706     5730   +24     
  Branches                    1925     1908   -17     
======================================================
+ Hits                        5145     5167   +22     
- Misses                       552      554    +2     
  Partials                       9        9
Flag Coverage Δ
pull-request 90.17% <94.28%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

LinKCoding added 20 commits July 1, 2026 16:22
@LinKCoding
clean up prop and add new story
2c47b8e
@LinKCoding
move back closeOnClick and update more stories
90c8362
@LinKCoding
merged in feature branch
ca58da4
@LinKCoding
first attempt at closing tooltip after click
31e06c8
@LinKCoding
removed zIndex from tip props
6040b72
@LinKCoding
InlineToolTip now a state instead of style, added testing for onClick
3d9c0f6
@LinKCoding
fix various bugs
919ec6a
@LinKCoding
added stories
d71e6a6
@LinKCoding
fix up errors
67500ec
@LinKCoding
update MenuItem tooltip
5ba17d2
@LinKCoding
update MenuItem type
cc8fc93
@LinKCoding
updated supressed => dismissed
f5ee226
@LinKCoding
undoing some type changes
1624b7d
@LinKCoding
add version plan
07d8f35
@LinKCoding
clean up prop and add new story
1ce3ee9
@LinKCoding
move back closeOnClick and update more stories
56c0b4b
@LinKCoding
remove unused story
061b086
@LinKCoding
add true default to tooltips closing on click
2146566
@LinKCoding
merge feature branch
a566e2f
@LinKCoding
Merge branch 'cass-gmt-1607-publish' into kl-gmt-1666-gamut-beta
7b0ce6e
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

🚀 Styleguide deploy preview ready!

Preview URL: https://6a58e4d4189f411719a0b41b--gamut-preview.netlify.app
Deploy Logs: https://app.netlify.com/projects/gamut-preview/deploys/6a58e4d4189f411719a0b41b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do not merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@LinKCoding